Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support for Custom Loop Resources #229

Closed
jchrys opened this issue Feb 9, 2024 · 0 comments · Fixed by #232
Closed

[feature] Support for Custom Loop Resources #229

jchrys opened this issue Feb 9, 2024 · 0 comments · Fixed by #232
Assignees
@jchrys
Labels
enhancement New feature or request
Milestone
1.1.2

Comments

@jchrys
Copy link
Collaborator

jchrys commented Feb 9, 2024

Is your feature request related to a problem? Please describe.
Currently, r2dbc-mysql lacks support for custom loopResources. This limitation hinders the ability to optimize performance and manage resources efficiently, especially in scenarios requiring customized event loop management.

Describe the solution you'd like
I propose the introduction of support for custom loop resources via MySqlConnectionConfiguration builder.

Additional context
The need for custom loop resource support is exemplified by the issue discussed in r2dbc-pool#190, where it was observed that using custom loopResources could avoid accidental thread co-location, enhancing performance.
@jchrys jchrys added the enhancement New feature or request label Feb 9, 2024
@jchrys jchrys self-assigned this Feb 13, 2024
jchrys added a commit that referenced this issue Feb 13, 2024
@jchrys
Add LoopResources Configuration Support
329fc83 
Motivation:
Enhances flexibility by allowing custom `LoopResources` configuration for optimized event loop management.

Modifications:
Introduced `LoopResources` configuration option in `MysqlConnectionConfiguration` and updated relevant documentation.

Result:
Enables performance tuning and flexibility, improving adaptability for various deployment scenarios.
Resolves #229
@jchrys jchrys mentioned this issue Feb 13, 2024
Merged
jchrys added a commit that referenced this issue Feb 13, 2024
@jchrys
Add LoopResources Configuration Support
2ece1c7 
Motivation:
Enhances flexibility by allowing custom `LoopResources` configuration for optimized event loop management.

Modifications:
Introduced `LoopResources` configuration option in `MysqlConnectionConfiguration` and updated relevant documentation.

Result:
Enables performance tuning and flexibility, improving adaptability for various deployment scenarios.
Resolves #229
jchrys added a commit that referenced this issue Feb 14, 2024
@jchrys
Add LoopResources Configuration Support (#232)
aff4cc5 
Motivation:
Enhances flexibility by allowing custom `LoopResources` configuration
for optimized event loop management.

Modifications:
Introduced `LoopResources` configuration option in
`MysqlConnectionConfiguration` and updated relevant documentation.

Result:
Enables performance tuning and flexibility, improving adaptability for
various deployment scenarios. Resolves #229
@jchrys jchrys added this to the 1.1.2 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchrys jchrys

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.2
Development

Successfully merging a pull request may close this issue.

Add LoopResources Configuration Support asyncer-io/r2dbc-mysql
1 participant
@jchrys