Enforce $ name for named system actors (#1650)

* Enforce system actor names starts with $
asynkron · Jun 4, 2022 · b7d0669 · b7d0669
1 parent 2d7f16e
commit b7d0669
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Proto.Actor/Context/SystemContext.cs b/src/Proto.Actor/Context/SystemContext.cs
@@ -14,6 +14,12 @@ public static class SystemContext
 
     public static PID SpawnNamedSystem(this RootContext self, Props props, string name)
     {
+        if (!name.StartsWith("$"))
+        {
+            Logger.LogError("SystemContext Failed to spawn system actor {Name}", name);
+            throw new ArgumentException("System actor names must start with $", nameof(name));
+        }
+
         try
         {
             var parent = props.GuardianStrategy is not null

diff --git a/tests/Proto.Cluster.Tests/PubSubTests.cs b/tests/Proto.Cluster.Tests/PubSubTests.cs
@@ -264,7 +264,6 @@ async Task Receive(IContext context)
                         Deliveries.Add(new Delivery(context.ClusterIdentity()!.Identity, msg.Data));
                         context.Respond(new Response());
                         break;
-
                     case Subscribe msg:
                         await context.Cluster().Subscribe(msg.Topic, context.ClusterIdentity()!);
                         context.Respond(new Response());