Allow logging deadletter response

src/Proto.Actor/Configuration/ActorSystemConfig.cs

@@ -81,6 +81,7 @@ public record ActorSystemConfig
     ///     The default timeout for RequestAsync calls
     /// </summary>
     public TimeSpan ActorRequestTimeout { get; init; } = TimeSpan.FromSeconds(5);
+    public bool DeadLetterResponseLogging { get; init; } = false;
 
     /// <summary>
     ///     Creates a new default ActorSystemConfig
@@ -112,6 +113,8 @@ public ActorSystemConfig WithThreadPoolStatsTimeout(TimeSpan threadPoolStatsTime
     public ActorSystemConfig WithDeveloperThreadPoolStatsLogging(bool enabled) => this with {DeveloperThreadPoolStatsLogging = enabled};
 
     public ActorSystemConfig WithActorRequestTimeout(TimeSpan timeout) => this with {ActorRequestTimeout = timeout};
+
+    public ActorSystemConfig WithDeadLetterResponseLogging(bool enabled) => this with {DeadLetterResponseLogging = enabled};
 }
 
 //Not part of the contract, but still shipped out of the box

src/Proto.Actor/Context/BatchContext.cs

@@ -39,6 +39,10 @@ public async Task<T> RequestAsync<T>(PID target, object message, CancellationTok
         switch (result)
         {
             case DeadLetterResponse:
+                if (_context.System.Config.DeadLetterResponseLogging)
+                {
+                    Logger.LogError("BatchContext {Self} got DeadLetterResponse for PID {Pid}", _context.Self , target);
+                }
                 throw new DeadLetterException(target);
             case null:
             case T:

src/Proto.Actor/Context/ISenderContext.cs

@@ -6,6 +6,7 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
 using Proto.Context;
 using Proto.Future;
 
@@ -58,6 +59,7 @@ public interface ISenderContext : IInfoContext
 
 public static class SenderContextExtensions
 {
+    private static readonly ILogger Logger = Log.CreateLogger(nameof(SenderContextExtensions));
     /// <summary>
     /// Creates a batch context for sending a set of requests from the same thread context.
     /// This is useful if you have several messages which shares a cancellation scope (same cancellationToken).
@@ -173,6 +175,10 @@ internal static async Task<T> RequestAsync<T>(this ISenderContext self, PID targ
         switch (messageResult)
         {
             case DeadLetterResponse:
+                if (self.System.Config.DeadLetterResponseLogging)
+                {
+                    Logger.LogError("Context {Self} got DeadLetterResponse for PID {Pid}", self.Self , target);
+                }
                 throw new DeadLetterException(target);
             case null:
             case T:

src/Proto.Cluster/Gossip/GossipActor.cs

@@ -112,7 +112,7 @@ private Task OnGossipRequest(IContext context, GossipRequest gossipRequest)
 
         context.RequestReenter<GossipResponseAck>(context.Sender!, new GossipResponse
             {
-                State = memberState.State
+                State = memberState.State.Clone(), //ensure we have a copy and not state that might mutate
             }, task => ReenterAfterResponseAck(context, task, memberState), context.CancellationToken
         );
 
@@ -159,7 +159,7 @@ private void SendGossipForMember(IContext context, Member member, InstanceLogger
         context.RequestReenter<object>(pid, new GossipRequest
             {
                 MemberId = context.System.Id,
-                State = memberStateDelta.State
+                State = memberStateDelta.State.Clone(), //ensure we have a copy and not send state that might mutate
             },
             task => GossipReenterAfterSend(context, task, memberStateDelta),
             CancellationTokens.WithTimeout(_gossipRequestTimeout)

src/Proto.Remote/Endpoints/ServerConnector.cs

@@ -166,7 +166,7 @@ await call.RequestStream.WriteAsync(new RemoteMessage
                                         var sw = Stopwatch.StartNew();
                                         await call.RequestStream.WriteAsync(message).ConfigureAwait(false);
                                         sw.Stop();
-                                        RemoteMetrics.RemoteWriteDuration.Record(sw.ElapsedMilliseconds, _metricTags);
+                                        RemoteMetrics.RemoteWriteDuration.Record(sw.Elapsed.TotalSeconds, _metricTags);
                                     }
                                     else
                                     {