Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub sub fix for delivery to stopped subscribers + message renames #1667

Merged
merged 10 commits into from
Jun 10, 2022

Conversation

marcinbudny
Copy link
Contributor

@marcinbudny marcinbudny commented Jun 10, 2022

Description

  • Added failed delivery reporting back to TopicActor
  • If the subscriber is no longer reachable (was stopped), then topic will automatically unsubscribe it. This fixed the issue with topic actor being no longer usable, after subscriber is stopped without call to Unsubscribe.
  • Changed internal message names to be more readable
  • BREAKING: PublisherBatchMessage was renamed to PubSubBatch, which is important for the BatchingProducer error handler configuration.
  • PubSubDeliveryActor now uses ReenterAfter to improve throughput when multiple topics are delivering messages.
  • Pub sub tests moved out to separate project.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit 2fc538d into asynkron:dev Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants