Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even more xml docs + small changes #1699

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Even more xml docs + small changes #1699

merged 1 commit into from
Jul 4, 2022

Conversation

marcinbudny
Copy link
Contributor

Description

  • XML docs for OpenTelemetry and Persistence
  • ActivitySetup in OpenTelemetry now doesn't have to deal with null activities
  • Parameter renamed in Persistence to be more consistent actorName -> actorId

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit e15c9f4 into asynkron:dev Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeralsing rogeralsing Awaiting requested review from rogeralsing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinbudny @rogeralsing @marcinbudny-etteplan