-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Pub-Sub guarantees to at-most-once #1713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/Proto.Cluster.PubSub.Tests/Proto.Cluster.PubSub.Tests.csproj
This was referenced Jul 13, 2022
mhelleborg
reviewed
Jul 14, 2022
mhelleborg
reviewed
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After testing the pub-sub functionality on production it became clear that the aim for at-least-once delivery is not very well aligned with soft real-time, in-memory processing approach promoted by proto.actor. Additionally, ensuring at-least-once delivery has proven to increase complexity of the code and configuration significantly. This PR switches to at-most-once guarantee to align better with promoted use cases for the pub-sub.
Reliable stream processing is still relevant use case, and we may introduce a dedicated functionality that supports it in the future. For now we suggest using external infrastructure like Kafka or RabbitMQ in conjunction with proto.actor to ensure at-least-once processing.
Purpose
This pull request is a:
Checklist