Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API cleanup #1751

Merged
merged 13 commits into from
Sep 13, 2022
Merged

Public API cleanup #1751

merged 13 commits into from
Sep 13, 2022

Conversation

marcinbudny
Copy link
Contributor

Description

This pull requests aims to clean public API surface before 1.0 release. List of changes:

Item Change
Proto.ActorSystem.Stopper Made internal. Use ShutdownAsync to stop actor system, StoppedReason to retrieve reason for shutdown
Proto.ActorSystem.ConfigureProps, ConfigureSystemProps Made internal.
Proto.IContext.Stash() Related functionality removed. Use IContext.Capture and CapturedContext.Receive
Proto.PID.SendSystemMessage() Made internal.
Proto.Channels.ChannelPublisher, ChannelSubscriber Removed and converted to an example.
Proto.MessageBatch Removed.
Proto.Utils.TypeDictionary Made internal
Proto.ActorContextExtras.Store Made internal. Use Proto.ActorContext.Get, Set, Remove
Proto.Remote.GrpcNet.Extensions.AddRemote, AddClientRemote, UseProtoRemote Made internal.
Proto.Cluster.ClusterConfig.TimeoutTimespan Made obsolete. Use ActorActivationTimeout instead. The TimeoutTimespan implementation is now a proxy for ActorActivationTimeout
Proto.Cluster.ClusterConfig.ActorSpawnTimeout Renamed to ActorSpawnVerificationTimeout
Proto.Cluster.Cluster.Logger, PidCache, TryGetClusterKind Made internal.
Proto.Cluster.MemberList.TopologyConsensus, GetActivator, GetMetaMember, TryGetMemberIndexByAddress, TryGetMemberByIndex Made internal.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@mhelleborg mhelleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@rogeralsing rogeralsing merged commit d56ddd1 into asynkron:dev Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants