Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed K8s provider to use annotations instead of labels for kind propagation #1772

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

mhelleborg
Copy link
Member

Description

Fixes #1752, removes limitations around cluster kind naming.

Breaking changes

  • Changes kind propagation for K8s, will not work together with older versions of the provider

This allows for up to 63 characters for kind name
…e cluster kinds. This removes the restrictions on the kind names to match K8s label rules.
# Conflicts:
#	benchmarks/KubernetesDiagnostics/KubernetesDiagnostics.csproj
#	benchmarks/KubernetesDiagnostics/Program.cs
#	src/Proto.Cluster.CodeGen/CodeGenerator.cs
#	src/Proto.Cluster.Kubernetes/KubernetesProvider.cs
@mhelleborg mhelleborg merged commit 1593dd9 into dev Sep 30, 2022
@mhelleborg mhelleborg deleted the grains-namespace branch September 30, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update pod labels, registration failed on K8S
2 participants