Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a remark about canceling send done with the scheduler #1789

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

mlinnosk
Copy link
Contributor

@mlinnosk mlinnosk commented Oct 6, 2022

Description

It can be misleading for the user that when an actor using the scheduler is stopped or restarted the send tasks are not automatically cancelled. This can lead to resource leaks or duplicate sends when the actor is restarted.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2022

CLA assistant check
All committers have signed the CLA.

It can be misleading for the user that when an actor using the scheduler
is stopped or restarted the send tasks are not automatically cancelled.
This can lead to resource leaks or duplicate sends when the actor is restarted.
@rogeralsing rogeralsing merged commit ae7f48a into asynkron:dev Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants