Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it turns out, timing shutdowns is very hard to manage. I ended up putting the "stopping" variable back into the member list to ensure that it doesn't call
Cluster().ShutdownAsync()
again before it actually gets to theSystem.ShutdownAsync()
. This will ensure that it is only called once if it's initiated by itself. The next thing I did was to changeEndpointTerminatedEvent
'sOnError
property toShouldBlock
because I found that even in a graceful termination, the code right now will attempt to reconnect to a node that it "just" terminated because the gossip actor likely has messages in its mailbox where the "Respond" PID includes the node that should be removed. By pausing reconnections, the errors I was seeing around reconnects seem to have disappeared.Purpose
This pull request is a:
Checklist