Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fully qualified global namespaces when referencing internal classes #1849

Merged
merged 5 commits into from
Dec 30, 2022

Conversation

jupjohn
Copy link
Contributor

@jupjohn jupjohn commented Nov 14, 2022

Description

This PR aims to fix compilation errors when doing source gen inside of a Cluster namespace. Fixes #1840

I'm leaving this as a draft until I can get home and resign my commits with my PGP key.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

I don't believe the following need to be done for this as functionality will be confirmed by existing tests.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2022

CLA assistant check
All committers have signed the CLA.

@jupjohn
Copy link
Contributor Author

jupjohn commented Nov 14, 2022

There's another issue I found indirectly referencing the usage of global:: fully qualified namespaces (after I submitted my own) but I can't for the life of me find it now. If anyone managed to find it, it could probably be closed off too :)

@jupjohn jupjohn force-pushed the fix/1840-use-global-namespace branch from eb09b5c to 327d4a4 Compare November 16, 2022 04:20
@jupjohn jupjohn marked this pull request as ready for review November 16, 2022 04:21
@rogeralsing rogeralsing merged commit 04d80e2 into asynkron:dev Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating grains in project contaning "Cluster" namespace breaks sourcegen
3 participants