Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AzureContainerApps into src folder and minor cleanup #1901

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Move AzureContainerApps into src folder and minor cleanup #1901

merged 6 commits into from
Feb 8, 2023

Conversation

sfmskywalker
Copy link
Contributor

@sfmskywalker sfmskywalker commented Jan 10, 2023 •
edited
Loading

This PR brings a couple of small improvements:

  • Moves the AzureContainerApps project into the /src folder for consistency (and should also fix the issue that the package doesn't appear with a proper Proto.Actor package icon).
  • Simplifies the provider's constructor by defaulting to ENV variables automatically provided by the Azure Container App environment. Explicitly providing replica name, app name etc. is useful for debugging.

@sfmskywalker sfmskywalker marked this pull request as ready for review January 10, 2023 19:20
@rogeralsing rogeralsing merged commit 45332e8 into asynkron:dev Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfmskywalker @rogeralsing