Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LoggerMessage for logging in ActorContext #1907

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

woksin
Copy link
Contributor

@woksin woksin commented Jan 19, 2023

Description

Start introducing LoggerMessage slowly by using it in ActorContext. Refering to this issue #1651 where we talked about introducing it and to see how it would look. I use it in some projects and IMO I think it provides good readability, seperation of concerns at the same time of improving performance :)

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@woksin
Copy link
Contributor Author

woksin commented Jan 20, 2023

Weird with these failing tests as they should not really be affected by these changes :)

@rogeralsing rogeralsing merged commit d424276 into asynkron:dev Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants