Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable heartbeat expiration #2026

Merged
merged 1 commit into from
Jun 27, 2023
Merged

disable heartbeat expiration #2026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions benchmarks/KubernetesDiagnostics/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@

var app = builder.Build();

app.MapGet("/", async (Cluster cluster) =>
{

});
app.MapGet("/", (Cluster cluster) => Task.CompletedTask);

app.MapHealthChecks("/health");

Expand Down
5 changes: 2 additions & 3 deletions src/Proto.Cluster.Kubernetes/KubernetesProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ public async Task<DiagnosticsEntry[]> GetDiagnostics()
var res = await client.ListNamespacedPodWithHttpMessagesAsync(
KubernetesExtensions.GetKubeNamespace(),
labelSelector: selector,
watch: false,
timeoutSeconds: _config.WatchTimeoutSeconds
).ConfigureAwait(false);
timeoutSeconds: _config.WatchTimeoutSeconds,
watch: false).ConfigureAwait(false);

var pods = new DiagnosticsEntry("KubernetesProvider", "Pods", res.Body);

Expand Down
2 changes: 1 addition & 1 deletion src/Proto.Cluster.Kubernetes/Proto.Cluster.Kubernetes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<ItemGroup>
<PackageReference Include="JsonPatch.Net" Version="1.1.2" />
<PackageReference Include="KubernetesClient" Version="7.1.3-g341580fb9b" />
<PackageReference Include="KubernetesClient" Version="7.2.19" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Proto.Cluster/ClusterConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private ClusterConfig(string clusterName, IClusterProvider clusterProvider, IIde
GossipRequestTimeout = TimeSpan.FromMilliseconds(1500);
GossipFanout = 3;
GossipMaxSend = 50;
HeartbeatExpiration = TimeSpan.FromSeconds(20);
HeartbeatExpiration = TimeSpan.Zero;
ClusterRequestDeDuplicationWindow = TimeSpan.FromSeconds(30);
IdentityLookup = identityLookup;
MemberStrategyBuilder = (_, _) => new SimpleMemberStrategy();
Expand Down
Loading