Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis member store for ACA provider and manage stale members #2035

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

sfmskywalker
Copy link
Contributor

@sfmskywalker sfmskywalker commented Aug 28, 2023

Description

This PR adds a Redis store implementation as an alternative option to using Azure Resource tagging.

In addition, the ACA cluster provider is updated to remove stale member entries. This monitoring logic, as wel las registering and unregistering members, has been moved to an actor class to keep the provider class itself clean.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@sfmskywalker sfmskywalker marked this pull request as ready for review August 28, 2023 20:17
@rogeralsing rogeralsing merged commit d77dbaa into asynkron:dev Aug 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants