Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA Cluster Provider Improvements #2036

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Conversation

sfmskywalker
Copy link
Contributor

Description

This PR improves two aspects of the ACA cluster provider:

  1. When it is determined that a revision is inactive, we can expire it immediately instead of waiting for its timestamp to expire.
  2. Instead of hardcoding the member host to be whatever is returned from IPUtils, use the host from the cluster itself, which is configured external from the application itself using RemoteConfig

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit 32fc17b into asynkron:dev Sep 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants