Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardened cluster-request deduplication #2041

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Hardened cluster-request deduplication #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0345a6d
Harden cluster request deduplication by keeping a sliding window of l…
mhelleborg Sep 6, 2023
ebdd7a4
Bump default deduplication window to 1 min.
mhelleborg Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Proto.Actor/Deduplication/DeduplicationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ public async Task DeDuplicate(MessageEnvelope envelope, Func<Task> continuation)
if (IsDuplicate(key!, cutoff))
{
_logger.LogInformation("Request de-duplicated");
// Update timestamp to keep a sliding window of TTL
_processed[key!]= now;

return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Proto.Cluster/ClusterConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private ClusterConfig(string clusterName, IClusterProvider clusterProvider, IIde
GossipFanout = 3;
GossipMaxSend = 50;
HeartbeatExpiration = TimeSpan.Zero;
ClusterRequestDeDuplicationWindow = TimeSpan.FromSeconds(30);
ClusterRequestDeDuplicationWindow = TimeSpan.FromMinutes(1);
IdentityLookup = identityLookup;
MemberStrategyBuilder = (_, _) => new SimpleMemberStrategy();
RemotePidCacheTimeToLive = TimeSpan.FromMinutes(15);
Expand Down
Loading