Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecs provider fix #2056

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Ecs provider fix #2056

merged 2 commits into from
Sep 22, 2023

Conversation

dariussantaras
Copy link
Contributor

Description

Fixes #2055

  • The ECS 'describe tasks' SDK call now specifies the cluster explicitly.
  • ECS monitoring poll interval is now correctly converted into seconds.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit 48b2218 into asynkron:dev Sep 22, 2023
13 checks passed
@dariussantaras dariussantaras deleted the ecs-provider-fix branch September 25, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amazon ECS cluster provider fails with AWS error
3 participants
@dariussantaras @CLAassistant @rogeralsing