Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an Advertised Host other than PodIP when using Kubernetes cluster provider #2097

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

AdamCLarsen
Copy link
Contributor

Description

This PR introduces an enhancement to the Kubernetes cluster provider to allow an advertised host to be added as a Pod label, when not using the PodIP. This feature for scenarios where the fully qualified domain name (FQDN) is needed, for example, when using TLS to secure the communications within the cluster. This change include logic to detected the pod subdomain, namespace, and cluster domain, to attempt to keep the hostname stored in the label under k8s's max length of 63 chars for Pod Label values.

When workloads of type Deployment are joining the Proto.Actor cluster, it is recommended to create a headless services definition, and to also add a spec.subdomain to the Pod definition that matches the name of the assigned headless service. See examples/ClusterK8sGrains for a working example.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

hardened GetKubeNamespace() so it will not read in more data then kuberneties allows for a namespace, it will also now throw a with a descriptive error exception message vs FileNotFound.
@rogeralsing rogeralsing merged commit af1a612 into asynkron:dev Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants