Added support for propagating OpenTelemetry baggage #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeralsing
reviewed
Mar 18, 2024
| @@ -312,6 +313,11 @@ public static void Send(string source, PID target, object message, ActivitySetup | |||
|
|
|||
| var propagationContext = envelope.Header.ExtractPropagationContext(); | |||
|
|
|||
| if (propagationContext.Baggage.Count > 0) | |||
| { | |||
| Baggage.Current = propagationContext.Baggage; | |||
There was a problem hiding this comment.
TLDR on this?
It extracts baggage via header values.
then set the Baggage.Current to an actual baggage.
and then create a new activity via BuildStartedActivity,
and BuildStartedActivity extracts data from Baggage.Current into the new activity?
mhelleborg
force-pushed
the
otel-baggage
branch
from
6fcabb8
to
199c66e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for propagating Baggage via OTEL, by populating Baggage.Current if received in PropagationContext. Added tests to cover baggage propagation
Purpose
This pull request is a:
Checklist