Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using await on types implementing IAsyncDisposable #2114

Merged

Conversation

AmirShitrit
Copy link
Contributor

Description

Using await using on types implementing IAsyncDisposable.
Also, awaiting on ExecuteNonQueryAsync where it's used, in order to get a clearer callstack when exceptions are thrown.
In addition, returning index + 1 in PersistEventAsync instead of index++ which also needlessly modifies index.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Simple performance and debuggability improvements

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • No new tests are necessary

@rogeralsing rogeralsing merged commit 22d88fd into asynkron:dev Apr 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants