Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some internal properties as public #2127

Merged
merged 1 commit into from
May 20, 2024

Conversation

jstnlef
Copy link
Contributor

@jstnlef jstnlef commented May 20, 2024

Description

In order to write a proper alternative to the DefaultClusterContext, we need these properties to be public. I believe they should be considering that the API does allow end users to swap the IClusterContext with the WithClusterContextProducer method on ClusterConfig

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

In order to write a proper alternative to the DefaultClusterContext, we need these properties to be public
@rogeralsing rogeralsing merged commit d005018 into asynkron:dev May 20, 2024
18 checks passed
@jstnlef jstnlef deleted the expose-internal-properties branch May 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants