Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel ActorContextDecorator should support all ReenterAfter overloads #2138

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

kasperhhk
Copy link
Contributor

Description

Currently only 2 of the 5 overloads for ReenterAfter is supported by the OpenTelemetryActorContextDecorator. This causes telemetry to be lost when using the unsupported variants.

We encountered problems with our system where we had to manually re-set the Baggage, because we called one of the unsupported ReenterAfter overloads. With this fix it should mean we don't have to do this anymore.

I have added tests that cover each of the overloads (expectedly 3 out of 5 failed before the fix).

Suggestions for naming and improvements to the tests are welcome, I just made the simplest tests i could think of to test the problem.

However since I am making changes to the ActorContextDecorator base class, it may have implications for all other decorators. It might be necessary to take a look and see if those need updating to make sure they implement the missing overloads too.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit 4bbf51b into asynkron:dev Oct 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants