useless event hide

[darul75]

hi,
it looks like we get borderline effect with following lines

    var startEvent = $.Event('hide.bs.sidebar')
    this.$element.trigger(startEvent)

at the end, style="display:none" is added on dom element.

I do not know if jquery hide() method is called...but as this event is not used in your code, I propose to remove it.

PR coming

[darul75]

well, to give more details, here is a jquery-1.11-1 version code

trigger: function( event, data, elem, onlyHandlers ) {
        var handle, ontype, cur,
            bubbleType, special, tmp, i,
            eventPath = [ elem || document ],
            type = hasOwn.call( event, "type" ) ? event.type : event,
            namespaces = hasOwn.call( event, "namespace" ) ? event.namespace.split(".") : [];

        cur = tmp = elem = elem || document;

        // Don't do events on text and comment nodes
        if ( elem.nodeType === 3 || elem.nodeType === 8 ) {
            return;
        }

        // focus/blur morphs to focusin/out; ensure we're not firing them right now
        if ( rfocusMorph.test( type + jQuery.event.triggered ) ) {
            return;
        }

        if ( type.indexOf(".") >= 0 ) {
            // Namespaced trigger; create a regexp to match event type in handle()
            namespaces = type.split(".");
            type = namespaces.shift();
            namespaces.sort();
        }
        ontype = type.indexOf(":") < 0 && "on" + type;

        // Caller can pass in a jQuery.Event object, Object, or just an event type string
        event = event[ jQuery.expando ] ?
            event :
            new jQuery.Event( type, typeof event === "object" && event );
....

I do not know if it was your choice or not but by calling event ''hide.bs.sidebar', above code split it in 'hide' event and apply it.

So it simply hide and add display css value with side effects.

Maybe just rename event name will fix it too, what do you think, thanks ?