-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
第08章 実装を隠す #12
Merged
Merged
第08章 実装を隠す #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancのtimesとDollarのtimesがにているので重複を省いていく。 |
もう二つのサブクラスは大した仕事をしていないので、この際消してしまいたい。が、一気に消すのはステップが大きすぎる。小さく進めていく。 |
crystalの場合はいい感じに型推論っぽいことをしているので、この時点でコンパイラはエラーを吐かない。(Money 型には times メソッドが定義されていない、、などのコンパイルエラー) |
利用者側からDollarのサブクラスを消すことができた。テストからサブクラスを消去したことで、既存のコードに影響を及ぼさずに継承構造を変える権利を得た。 |
あー、なるほど。こういうところになかなか気づけないから、「こうした方が良い」というイメージがわかないんだな。今回のこの修正で、疎結合になっていく具体的なステップがわかった。 |
TODO
|
振り返り
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
$5 * 2 = $10amountをprivateにするDollarの副作用どうする?equals5CHF*2=10CHFequalsの一般化FrancとDollarを比較する