Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request review #44

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Pull request review #44

merged 3 commits into from
Jan 20, 2023

Conversation

olivierodo
Copy link
Contributor

Change description

Create a pull request review when error has been found

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #32

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows project security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to issue tracker where applicable

@olivierodo olivierodo merged commit a059b8b into master Jan 20, 2023
@olivierodo olivierodo deleted the pull-request-review branch January 20, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a comment on the pull request
1 participant
@olivierodo