chore(lambda-nodejs): do not add unused environment variable by defau…

…lt for sdk v3 lambda runtimes (aws#30117) Closes aws#29497 Related to aws#29538 ### Reason for this change The `AWS_NODEJS_CONNECTION_REUSE_ENABLED` does not exist in SDK v3. Including it in the environment can add to cold start times. ### Description of changes For Lambda runtimes >= Node 18, do not set the variable by default. If set explicitly, give the user a warning. We can plan to simplify this logic & deprecate the property after we deprecate Node 16 and remove it as the default runtime for this construct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
atanaspam · Jun 3, 2024 · 75aa95d · 75aa95d
1 parent 6cde919
commit 75aa95d
Show file tree

Hide file tree

Showing 383 changed files with 88,561 additions and 15,377 deletions.
diff --git a/...dejs/test/integ.compilations.js.snapshot/cdk-integ-compilations-lambda-nodejs.assets.json b/...dejs/test/integ.compilations.js.snapshot/cdk-integ-compilations-lambda-nodejs.assets.json
diff --git a/...js/test/integ.compilations.js.snapshot/cdk-integ-compilations-lambda-nodejs.template.json b/...js/test/integ.compilations.js.snapshot/cdk-integ-compilations-lambda-nodejs.template.json
@@ -40,11 +40,6 @@
      },
      "S3Key": "2344c8450ec3c069ed98fedf1714f33c31b9f3c8e0d295ea361224732e1fef37.zip"
     },
-    "Environment": {
-     "Variables": {
-      "AWS_NODEJS_CONNECTION_REUSE_ENABLED": "1"
-     }
-    },
     "Handler": "index.handler",
     "Role": {
      "Fn::GetAtt": [
@@ -98,11 +93,6 @@
      },
      "S3Key": "112c693f98d7e411850f8d441167216bdfe392567d99a11e03b6cd921e36398b.zip"
     },
-    "Environment": {
-     "Variables": {
-      "AWS_NODEJS_CONNECTION_REUSE_ENABLED": "1"
-     }
-    },
     "Handler": "index.handler",
     "Role": {
      "Fn::GetAtt": [

diff --git a/...esting/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/cdk.out b/...esting/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/cdk.out
diff --git a/...ing/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/integ.json b/...ing/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/integ.json
diff --git a/.../framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/manifest.json b/.../framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/manifest.json
diff --git a/...ting/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/tree.json b/...ting/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.js.snapshot/tree.json
diff --git a/...t/integ.dependencies-pnpm.js.snapshot/PnpmTestDefaultTestDeployAssert397EDF83.assets.json b/...t/integ.dependencies-pnpm.js.snapshot/PnpmTestDefaultTestDeployAssert397EDF83.assets.json
diff --git a/...integ.dependencies-pnpm.js.snapshot/PnpmTestDefaultTestDeployAssert397EDF83.template.json b/...integ.dependencies-pnpm.js.snapshot/PnpmTestDefaultTestDeployAssert397EDF83.template.json
diff --git a/...teg/test/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/TestStack.assets.json b/...teg/test/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/TestStack.assets.json