Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

config/config.go:207:17: Error return value of fh.Close is not checked (errcheck) #104

Closed
atc0005 opened this issue Jul 21, 2020 · 0 comments · Fixed by #119
Closed

config/config.go:207:17: Error return value of fh.Close is not checked (errcheck) #104

atc0005 opened this issue Jul 21, 2020 · 0 comments · Fixed by #119
Assignees
Labels
bug Something isn't working linting
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Jul 21, 2020

Found this after using --exclude-use-default=false with version v1.29.0.

$ golangci-lint run -v --exclude-use-default=false
# ...
config/config.go:207:17: Error return value of `fh.Close` is not checked (errcheck)
                defer fh.Close()
@atc0005 atc0005 added bug Something isn't working linting labels Jul 21, 2020
@atc0005 atc0005 added this to the Next Release milestone Jul 21, 2020
@atc0005 atc0005 self-assigned this Jul 21, 2020
atc0005 added a commit that referenced this issue Jul 22, 2020
- Wrap deferred file close with error check/logging
- Add explicit file close with error check/logging
- Emit func name for both cases to aid in troubleshooting

refs GH-104
atc0005 added a commit that referenced this issue Jul 23, 2020
Complete the work for this func that was started with commit
f2aafe9 for GH-104

- refs GH-104
- refs GH-124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working linting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant