Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Consider removing the option to ignore lookup errors (or at least change the scope of the option) #62

Open
atc0005 opened this issue Jun 24, 2020 · 0 comments
Open

Consider removing the option to ignore lookup errors (or at least change the scope of the option) #62

atc0005 opened this issue Jun 24, 2020 · 0 comments
Labels
config documentation Improvements or additions to documentation question Further information is requested
Milestone
Future

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 24, 2020

Currently the ignore-lookup-errors flag (and associated config file setting) allows ignoring lookup errors for:

  • disabled user accounts
  • ignored usernames
  • ignored IP Addresses

The latter two make some sense, but are still questionable as the resulting behavior would allow for disabling the associated account and terminating (if enabled) the associated user sessions.

The first seems to blindly assume that the user account has not been disabled yet and will attempt to disable it again.

This "feature" needs further consideration and potential removal to avoid unexpected behavior.
@atc0005 atc0005 added documentation Improvements or additions to documentation question Further information is requested config labels Jun 24, 2020
@atc0005 atc0005 added this to the Future milestone Jun 24, 2020
@atc0005 atc0005 changed the title Consider removing the option to ignore lookup errors or at least change their scope Consider removing the option to ignore lookup errors (or at least change their scope) Jun 24, 2020
@atc0005 atc0005 changed the title Consider removing the option to ignore lookup errors (or at least change their scope) Consider removing the option to ignore lookup errors (or at least change the scope of the option) Jun 24, 2020
atc0005 added a commit that referenced this issue Jun 24, 2020
@atc0005
WIP: More work on ProcessEvent() func, handling of IgnoreLookupErrors…
94c2d2c 
… per GH-62
atc0005 added a commit that referenced this issue Jun 28, 2020
@atc0005
WIP: More work on ProcessEvent() func, handling of IgnoreLookupErrors…
09de4e4 
… per GH-62
atc0005 added a commit that referenced this issue Jun 29, 2020
@atc0005
WIP: More work on ProcessEvent() func, handling of IgnoreLookupErrors…
2685f66 
… per GH-62
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
config documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@atc0005