This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Expose Teams notifications rate limit setting #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMMARY As a follow-up to GH-87, this commit exposes a new setting that allows directly configuring the rate limit used for Teams notifications. GH-3 will be responsible for exposing the same setting for email notifications. CHANGES - update documentation to note new setting - README - GoDoc - configure - configuration file - new `rate_limit` setting - code - remove rate limit constants in favor of external settings (email rate limit setting scheduled for GH-3) and default const value if not specified externally - new `TeamsNotificationRateLimit` getter func - new `EmailNotificationRateLimit` getter func - stub only; further work scheduled for GH-3 REFERENCES refs GH-87, GH-85, GH-19, GH-3
atc0005
added
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As a follow-up to GH-87, this commit exposes a new setting that
allows directly configuring the rate limit used for Teams
notifications. GH-3 will be responsible for exposing the same
setting for email notifications.
CHANGES
update documentation to note new setting
configuration file
rate_limitsettingcode
rate limit setting scheduled for Feature: Add support for email notifications when disabling user #3) and default const value if
not specified externally
TeamsNotificationRateLimitgetter funcEmailNotificationRateLimitgetter funcREFERENCES