Refactor certs state identification #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend `ChainStatus` type to bundle cert chain and threshold values - Replace `ServiceCheckStatus` field in `ChainStatus` type with method to provide this text label in addition to the appropriate exit code - Simplify `GenerateCertsReport()` func to only require a `ChainStatus` instead of multiple arguments - Update `OneLineCheckSummary()` so that an optional flag can be provided to toggle overall cert chain summary text and so that multiple other arguments are now replaced by a `ChainStatus` value - Provide and use `IsCriticalState()`, `IsWarningState()` and `IsOKState` `ChainStatus` methods to simplify and fix the logic for determining the final exit status for the service check. refs GH-188
|
Still need to update the documentation examples to reflect the fixed logic, so not closing GH-188 just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainStatustype to bundle cert chain and thresholdvalues
ServiceCheckStatusfield inChainStatustype withmethod to provide this text label in addition to the appropriate
exit code
GenerateCertsReport()func to only require aChainStatusinstead of multiple argumentsOneLineCheckSummary()so that an optional flag can beprovided to toggle overall cert chain summary text and so that
multiple other arguments are now replaced by a
ChainStatusvalue
IsCriticalState(),IsWarningState()andIsOKStateChainStatusmethods to simplify and fix the logicfor determining the final exit status for the service check.
refs GH-188