Explicitly disable use of cgo #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, the v0.2.5 release provided binaries that are *not* statically linked against glibc and thus would not be held to LGPL license requirements. AFAICT. Update Makefile to disable use of cgo for binary generation in an effort to avoid potential inclusion in the future. This is likely *not* the last time I'll need to update the Makefile build options for static binary generation, but hopefully this will do for now. refs #94 refs atc0005/mysql2sqlite#48
atc0005
deleted the
i94-explicitly-disable-cgo-instead-of-allowing-potential-for-static-inclusion-of-glibc
branch
atc0005
added a commit
to atc0005/check-cert
that referenced
this pull request
Oct 7, 2020
The previous build command produces dynamic executables instead of the intended (but not well noted in the Makefile) static executables. This commit includes changes noted in upstream `golang/go` issues which appear to work as intended for others. I also include doc comments and reference links describing the use of the updated build options list and some problems that I encountered during testing of `linkmode=external`. - refs GH-92 - refs atc0005/check-mail#94 - refs atc0005/check-mail#95 - refs atc0005/check-mail#101 - refs golang/go 38789 - refs golang/go 26492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the v0.2.5 release provided binaries
that are not statically linked against glibc and thus
would not be held to LGPL license requirements. AFAICT.
Update Makefile to disable use of cgo for binary generation
in an effort to avoid potential inclusion in the future.
This is likely not the last time I'll need to update
the Makefile build options for static binary generation,
but hopefully this will do for now.
refs #94
refs atc0005/mysql2sqlite#48