Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase use of constants for common string comparison cases #186

Closed
atc0005 opened this issue Dec 12, 2019 · 0 comments · Fixed by #188
Closed

Increase use of constants for common string comparison cases #186

atc0005 opened this issue Dec 12, 2019 · 0 comments · Fixed by #188
Assignees
@atc0005
Labels
enhancement New feature or request linting
Milestone
v0.7.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Dec 12, 2019

This is a continuation of the work from #176.

Non-exhaustive candidates for replacing bare strings with constants:

elbow/config/merge_incomplete_configs_test.go

Line 134 in 788742b

expectedLogLevelAfterFileMerge := "notice"

elbow/config/merge_incomplete_configs_test.go

Line 222 in 788742b

{"ELBOW_LOG_FORMAT", "text"},

elbow/config/merge_incomplete_configs_test.go

Lines 379 to 381 in 788742b

"--log-level", "panic",
"--log-format", "json",
"--console-output", "stderr",

@atc0005 atc0005 added enhancement New feature or request linting labels Dec 12, 2019
@atc0005 atc0005 added this to the v0.7.0 milestone Dec 12, 2019
@atc0005 atc0005 self-assigned this Dec 12, 2019
This was referenced Dec 13, 2019
Open
Merged
atc0005 added a commit that referenced this issue Dec 13, 2019
@atc0005
Increase use of constants for common cases
c04c5d5 
Replace common string values for Set*, Validate and other methods
and functions which are likely to result in (more) subtle bugs
in the future. I found at least one case where the emergency
option for the command-line flag --log-level was likely not
used as intended.

refs #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request linting
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Increase use of constants for common string comparison cases atc0005/elbow
1 participant
@atc0005