Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint "goconst" errors (WORKAROUND) #179

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Dec 12, 2019

  • Create minimum (or near about) constants to resolve golangci-lint's goconst linting tests

  • Drop a good many TODO markers for further refactoring work

This is meant to get the CI builds passing again and clearly note places that need further refinement for near-future focus work.

fixes #176

@atc0005 atc0005 added bug Something isn't working builds CI linting labels Dec 12, 2019
@atc0005 atc0005 added this to the v0.7.0 milestone Dec 12, 2019
@atc0005 atc0005 self-assigned this Dec 12, 2019
@atc0005 atc0005 force-pushed the i176-fix-goconst-linting-errors branch 2 times, most recently from 76c3ba0 to 54f9be9 Compare December 12, 2019 18:59
- Create minimum (or near about) constants to resolve
  golangci-lint's goconst linting tests

- Drop a good many TODO markers for further refactoring work

This is meant to get the CI builds passing again and clearly
note places that need further refinement for near-future
focus work.

refs #176
@atc0005 atc0005 force-pushed the i176-fix-goconst-linting-errors branch from 54f9be9 to ed0662d Compare December 12, 2019 19:31
@atc0005 atc0005 marked this pull request as ready for review December 12, 2019 19:33
@atc0005 atc0005 changed the title Fix golangci-lint "goconst" errors (PLACEHOLDER) Fix golangci-lint "goconst" errors Dec 12, 2019
@atc0005 atc0005 changed the title Fix golangci-lint "goconst" errors Fix golangci-lint "goconst" errors (WORKAROUND) Dec 12, 2019
@atc0005 atc0005 merged commit 788742b into master Dec 12, 2019
@atc0005 atc0005 deleted the i176-fix-goconst-linting-errors branch December 12, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builds CI linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint | string STRING has N occurrences, make it a constant (goconst)
1 participant