Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot: Move grouped Dockerfiles into separate subdirectories #204

Closed
atc0005 opened this issue Jan 20, 2021 · 1 comment · Fixed by #206
Closed

Dependabot: Move grouped Dockerfiles into separate subdirectories #204

atc0005 opened this issue Jan 20, 2021 · 1 comment · Fixed by #206
Assignees
@atc0005
Labels
bug Something isn't working CI dependencies enhancement New feature or request Makefile stable stable-build-only
Milestone
v0.3.7

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 20, 2021

Due to limitations noted in dependabot/dependabot-core#2179, PRs continue to be generated which attempt to flip some Dockerfiles from one container image to another. This results in a mix of intended and unintended changes.

Intended (example):

-FROM golang:1.15.6-alpine3.12
+FROM golang:1.15.7-alpine3.12

Unintended:

-FROM golang:1.15.6
+FROM golang:1.15.7-alpine3.12

To help prevent this bug from affecting future PRs to this project, I plan to separate out all Dockerfiles grouped in one directory path into separate subdirectories. This should hopefully resolve the issue (from this project's perspective).

This change will require updating the Makefile used to build the images, and the Dependabot configuration to duplicate the current stable section, once per each Dockerfile to reflect new paths.
@atc0005 atc0005 added this to the Next Release milestone Jan 20, 2021
@atc0005 atc0005 self-assigned this Jan 20, 2021
@atc0005 atc0005 changed the title Dependabot: Separate Dockerfiles, one per directory path Dependabot: Move grouped Dockerfiles into separate subdirectories Jan 20, 2021
@atc0005
Copy link
Owner Author

atc0005 commented Jan 20, 2021

See #202 (source of examples in OP).

atc0005 added a commit that referenced this issue Jan 20, 2021
@atc0005
Dependabot: Move Dockerfiles into separate subdirs
5806afa 
Instead of grouping all stable Dockerfiles together,
separate into subdirectories to provide Dependabot
an isolated view of the specific Docker image that
we wish for it to help maintain.

Update the Makefile to reflect the new paths.

refs GH-204
@atc0005 atc0005 mentioned this issue Jan 20, 2021
Merged
atc0005 added a commit that referenced this issue Jan 20, 2021
@atc0005
Dependabot: Move Dockerfiles into separate subdirs
c0e986e 
Instead of grouping all stable Dockerfiles together,
separate into subdirectories to provide Dependabot
an isolated view of the specific Docker image that
we wish for it to help maintain.

Update the Makefile to reflect the new paths.

Update the GitHub Actions Workflow for Dockerfile
linting to reflect the new paths, including some
Dockerfiles that I previously failed to include in
the list to check.

refs GH-204
@atc0005 atc0005 added the bug Something isn't working label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working CI dependencies enhancement New feature or request Makefile stable stable-build-only
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging a pull request may close this issue.

Dependabot: Move Dockerfiles into separate subdirs atc0005/go-ci
1 participant
@atc0005