Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional "Pre-Defined annotation Keys" to Dockerfiles #501

Closed
atc0005 opened this issue Feb 2, 2022 · 0 comments · Fixed by #502
Closed

Add additional "Pre-Defined annotation Keys" to Dockerfiles #501

atc0005 opened this issue Feb 2, 2022 · 0 comments · Fixed by #502
Assignees
@atc0005
Labels
documentation Improvements or additions to documentation enhancement New feature or request oldstable stable stable-build-only stable-lint-only unstable
Milestone
0.5.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 2, 2022

These labels look to be both useful and as I work on publishing images to the GitHub Container Registry it looks like several of them (e.g., description) are exposed to users viewing the images:

  • title
  • description
  • documentation
  • url
  • authors
  • created
  • revision

These would need to be set as part of the build process:

  • created
  • revision

refs:
@atc0005 atc0005 added documentation Improvements or additions to documentation enhancement New feature or request oldstable unstable stable stable-lint-only stable-build-only labels Feb 2, 2022
@atc0005 atc0005 self-assigned this Feb 2, 2022
@atc0005 atc0005 added this to the Next Release milestone Feb 2, 2022
atc0005 added a commit that referenced this issue Feb 2, 2022
@atc0005
Add additional "annotation keys" to images
f8ffbc7 
- static labels set in Dockerfiles
  - title
  - description
  - documentation
  - url
  - authors
- dynamic revision and created labels applied via Makefile
  - created
  - revision

refs GH-501
@atc0005 atc0005 mentioned this issue Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
documentation Improvements or additions to documentation enhancement New feature or request oldstable stable stable-build-only stable-lint-only unstable
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add additional "annotation keys" to images atc0005/go-ci
1 participant
@atc0005