Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump github.com/choffmeister/git-describe-semver from 0.3.11 to 0.4.0 in /tools #1275

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps github.com/choffmeister/git-describe-semver from 0.3.11 to 0.4.0.

Release notes

Sourced from github.com/choffmeister/git-describe-semver's releases.

v0.4.0

Changelog

  • 1235d19 Fix action
  • 92b2c9c Fix readme
  • e1fa986 Improve github action
  • d2b6ec0 Readd next-release support to action (#7)
  • cc4b917 Support git repository checkouts using git worktree (#1) (#5)
  • edfdd5c Update golang 1.21
  • 3862bfb feat: Next release version (#6)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@atc0005
Copy link
Owner

atc0005 commented Dec 15, 2023

This PR is on hold until this bug report can be resolved:

@atc0005
Copy link
Owner

atc0005 commented Jan 12, 2024

No response from the project maintainer(s) yet.

Digging into the changes between v0.3.11 and v0.4.0 the biggest difference (at first glance) that might explain the problem appears to be the change from using the flags standard library package to using the jessevdk/go-flags package.

Local testing replicates the error.

Digging further I find:

and reading the notes from that package's maintainer it is clear that support for explicitly setting a boolean flag value as false will not be provided.

Projects using this tool are not relying on that behavior, but I was relying on the ability to explicitly set a boolean configuration setting for the GitHub Action as false (which no longer works).

I'll plan to merge this and update the images to include the v0.4.0 release as doing so should not impact projects relying on the bundled binary.

Where I'm using the GitHub Action I'll plan to swap to using an explicit Docker container since the GH Action apparently has a different issue (set to use the latest container tag even if you specify an explicit version of the Action to use).

@atc0005
Copy link
Owner

atc0005 commented Jan 13, 2024

@dependabot rebase

Bumps [github.com/choffmeister/git-describe-semver](https://github.com/choffmeister/git-describe-semver) from 0.3.11 to 0.4.0.
- [Release notes](https://github.com/choffmeister/git-describe-semver/releases)
- [Changelog](https://github.com/choffmeister/git-describe-semver/blob/main/.goreleaser.yml)
- [Commits](choffmeister/git-describe-semver@v0.3.11...v0.4.0)

---
updated-dependencies:
- dependency-name: github.com/choffmeister/git-describe-semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/master/github.com/choffmeister/git-describe-semver-0.4.0 branch from 156ffc6 to 04f25d4 Compare January 13, 2024 16:41
@atc0005 atc0005 added this to the Next Release milestone Jan 13, 2024
@atc0005 atc0005 merged commit 1fa3eda into master Jan 13, 2024
15 checks passed
@atc0005 atc0005 deleted the dependabot/go_modules/tools/master/github.com/choffmeister/git-describe-semver-0.4.0 branch January 13, 2024 16:46
atc0005 added a commit that referenced this pull request Jan 13, 2024
- Update Dockerfile ENV values
- Update README tools version table

refs GH-1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant