Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip os.Exit call at end of plugin execution #147

Closed
atc0005 opened this issue Sep 17, 2022 · 0 comments · Fixed by #148
Closed

Add option to skip os.Exit call at end of plugin execution #147

atc0005 opened this issue Sep 17, 2022 · 0 comments · Fixed by #148
Assignees
@atc0005
Labels
enhancement New feature or request tests
Milestone
v0.10.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Sep 17, 2022

If tests call the ExitState.ReturnCheckResults method (which in turn calls os.Exit), this results in a panic when executed by Go 1.16 and newer. We need a way to signal to that method that os.Exit should be skipped.
@atc0005 atc0005 added enhancement New feature or request tests labels Sep 17, 2022
@atc0005 atc0005 added this to the Next Release milestone Sep 17, 2022
@atc0005 atc0005 self-assigned this Sep 17, 2022
atc0005 added a commit that referenced this issue Sep 17, 2022
@atc0005
Add option to skip os.Exit at plugin completion
5d3a153 
This is needed to properly test the ExitState.ReturnCheckResults
function using Go 1.16 and newer.

refs GH-147
@atc0005 atc0005 mentioned this issue Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request tests
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Add option to skip os.Exit at plugin completion atc0005/go-nagios
1 participant
@atc0005