Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to prevent further Service Output interpolation regressions #144

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Add test to prevent further Service Output interpolation regressions #144

merged 3 commits into from
Sep 16, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Sep 16, 2022

Overview

Apply a series of changes to help prevent further regressions:

  • move Service Output handling logic to helper function
    • consolidate logic in one place similar to how the other output sections (e.g., Errors, Long Service Output) are already handled to make this logic easier to test
  • add test case
    • intentionally restore regression by using fmt.Fprintf function in helper code
    • fix regression by using fmt.Fprint as intended, confirm expected behavior

References

@atc0005 atc0005 added enhancement New feature or request output/plugin plugin output intended for monitoring system ingest tests labels Sep 16, 2022
@atc0005 atc0005 added this to the Next Release milestone Sep 16, 2022
@atc0005 atc0005 self-assigned this Sep 16, 2022
@atc0005
Move Service Output handling logic to helper func
2ad736a 
Consolidate logic in one place similar to how the other
output sections (e.g., Errors, Long Service Output) are
already handled.
@atc0005
Add intentional regression, test case to catch it
169300c 
Revert (temporarily) to invalid behavior for Service Output
handling, provide test case to help prevent further regressions
in the future.

refs GH-139
refs GH-58
@atc0005 atc0005 force-pushed the i139-i58-prevent-further-service-output-interpolation-regressions branch from ba53331 to f3866d6 Compare September 16, 2022 11:17
@atc0005
Fix (temp) regression in Service Output handling
577bd9f 
Restore handling of Service Output to the intended "as-is"
or "passthrough" logic so that literal text is not
unintentionally processed as a formatting specifier string.

refs GH-139
refs GH-58
@atc0005 atc0005 force-pushed the i139-i58-prevent-further-service-output-interpolation-regressions branch from f3866d6 to 577bd9f Compare September 16, 2022 11:23
@atc0005 atc0005 merged commit 28d1e0a into master Sep 16, 2022
@atc0005 atc0005 deleted the i139-i58-prevent-further-service-output-interpolation-regressions branch September 16, 2022 11:30
@atc0005 atc0005 changed the title Prevent further Service Output interpolation regressions Add test to prevent further Service Output interpolation regressions Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request output/plugin plugin output intended for monitoring system ingest tests
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@atc0005