Add initial plugin output test #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hesitate to call this a true End to End (e2e) test, but this initial test configures an ExitState value as client code in the wild currently does and then asserts that the output matches the contents of a carefully crafted testdata file. NOTE: This test adds a dependency on the popular github.com/google/go-cmp testing package. Because future tests are planned which will also use this package, adding the dependency (only for tests) is deemed to be worth the "cost" of adding an external dependency (again, just for tests).
atc0005
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hesitate to call this a true End to End (e2e) test, but this initial test configures an ExitState value as client code in the wild currently does and then asserts that the output matches the contents of a carefully crafted testdata file.
NOTE:
This test adds a dependency on the popular
github.com/google/go-cmptesting package.Because future tests are planned which will also use this package, adding the dependency (only for tests) is deemed to be worth the "cost" of adding an external dependency (again, just for tests).