Clarify handling of empty payload input #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make changes to clarify what happens when empty input is provided to encoded payload methods. - update doc comments and behavior of payload related methods to explicitly handle empty input vs using previous implicit behavior of underlying buffer field - `(Plugin).AddPayloadBytes` - `(Plugin).AddPayloadString` - `(Plugin).SetPayloadBytes` - `(Plugin).SetPayloadString` - add new tests to lock-in the intended behavior for empty input for those payload related methods - `TestAddPayloadString_AppendsNothingWhenCalledWithEmptyInput` - `TestAddPayloadBytes_AppendsNothingWhenCalledWithEmptyInput` - `TestSetPayloadString_SetsInputSuccessfullyWhenCalledWithEmptyInput` - `TestSetPayloadBytes_SetsInputSuccessfullyWhenCalledWithEmptyInput` refs GH-251
atc0005
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make changes to clarify what happens when empty input is provided to encoded payload methods.
(Plugin).AddPayloadBytes(Plugin).AddPayloadString(Plugin).SetPayloadBytes(Plugin).SetPayloadStringTestAddPayloadString_AppendsNothingWhenCalledWithEmptyInputTestAddPayloadBytes_AppendsNothingWhenCalledWithEmptyInputTestSetPayloadString_SetsInputSuccessfullyWhenCalledWithEmptyInputTestSetPayloadBytes_SetsInputSuccessfullyWhenCalledWithEmptyInputReferences