forked from dasrick/go-teams-notify
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./send_test.go:238:8: second argument to errors.As should not be *error
#176
Comments
atc0005
added a commit
that referenced
this issue
Jul 18, 2022
Remove errors.As() comparison logic until I can determine how to use a table test configuration to reliably assert that an expected error is of a specific type. Tweak test failure message format slightly to improve readability. Add `name` field to table test struct, move test name comments from each table test into name value (so that each test case is properly labeled in output). Run each test case as a subtest in an effort to provide additional isolation. refs GH-176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Test output from Go 1.17.12
No errors/warnings with the "oldstable" version of Go, version 1.17.12 (linux/amd64):
Test output from Go 1.18.4
No errors/warnings with the current stable version of Go, version 1.18.4 (linux/amd64):
Test output from Go 1.19 (pre-release versions)
Same results using these 1.19 pre-release versions:
1.19beta1
1.19.rc1
1.19rc2
Output:
The text was updated successfully, but these errors were encountered: