Add initial support for Workflow connectors #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lower `AdaptiveCardMaxVersion` from `1.5` to `1.4`
- this almost seems like a bug on Teams' end as this limitation is
not communicated (from what I could tell) via
https://adaptivecards.io/designer/
- using a value of `1.4` appears to work equally well for O365 and
Workflow connectors
- treat a 202 response code as sufficient response verification
- instead of expecting a `1` in the response body as previously
confirmed
- see also #59
- add `logic.azure.com` to valid URL patterns for default validation
- debugging / troubleshooting
- log status code and response string for O365 connector responses
- log validation pattern match
refs GH-262
atc0005
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The issues raised by CodeQL are not really "security" issues per se (we're just trying to object to potentially invalid webhook URLs, not prevent usage), but are probably still worth addressing. |
atc0005
added a commit
that referenced
this pull request
Jul 24, 2024
THIS is the regex pattern intended for GH-277. Previous commit message: Switch from static base pattern of `logic.azure.com` to a regex OR pattern to permit either of `logic.azure.com` or `*.azure-api.net` as has been observed in the wild. This also has the side effect of resolving potential CodeQL alerts raised in PR GH-275. refs GH-262
Fixed by 7cdd311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AdaptiveCardMaxVersionfrom1.5to1.41.4appears to work equally well for O365 and Workflow connectors1in the response body as previously confirmedlogic.azure.comto valid URL patterns for default validationlogic.azure.comor*.azure-api.netas observed in the wildReferences