Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning: unqualified call to 'std::move' on clang 16. #162

Merged

Conversation

rururia-kyopro
Copy link
Contributor

This PR fixes following warning on clang 16 by explicitly qualify call for move.

.../ac-library-master/test/unittest/../../atcoder/convolution.hpp:261:27: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    auto c2 = convolution(move(a2), move(b2));
                          ^
                          std::
.../ac-library-master/test/unittest/../../atcoder/convolution.hpp:295:15: note: in instantiation of function template specialization 'atcoder::convolution<754974721U, long long, nullptr>' requested here
    auto c1 = convolution<MOD1>(a, b);
              ^

Steps to reproduce: Install clang 16 on Ubuntu 22.10 and run unittest.

This warning was introduced in clang 15.
link: https://reviews.llvm.org/D119670?id=408276

@yosupo06 yosupo06 merged commit e785647 into atcoder:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants