Skip to content

fix #51: add assert for mcf_graph.add_edge #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix #51: add assert for mcf_graph.add_edge #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions atcoder/mincostflow.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ template <class Cap, class Cost> struct mcf_graph {
int add_edge(int from, int to, Cap cap, Cost cost) {
assert(0 <= from && from < _n);
assert(0 <= to && to < _n);
assert(0 <= cap);
assert(0 <= cost);
int m = int(pos.size());
pos.push_back({from, int(g[from].size())});
int from_id = int(g[from].size());
Expand Down
9 changes: 8 additions & 1 deletion test/unittest/mincostflow_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,11 @@ TEST(MincostflowTest, SameCostPaths) {
ASSERT_EQ(2, g.add_edge(0, 2, 2, 1));
auto expected = std::vector<std::pair<int, int>>{{0, 0}, {3, 3}};
ASSERT_EQ(expected, g.slope(0, 2));
}
}

TEST(MincostflowTest, Invalid) {
mcf_graph<int, int> g(2);
// https://github.com/atcoder/ac-library/issues/51
EXPECT_DEATH(g.add_edge(0, 0, -1, 0), ".*");
EXPECT_DEATH(g.add_edge(0, 0, 0, -1), ".*");
}