Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #71: change system includes into local includes #72

Merged
merged 4 commits into from
Nov 14, 2020
Merged

Conversation

yosupo06
Copy link
Collaborator

We use #include <atcoder/internal_xxx> for including internal libraries, but using #include "internal_xxx" is better-behaved.

Copy link

@kmyk kmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating!
This looks good to me, in the sense of the usual best practice and in the sense of the combination with oj-bundle.

@kmyk
Copy link

kmyk commented Nov 14, 2020

BTW, some people may prefer #include "atcoder/convolution.hpp" than #include "convolution.hpp" because the former is more explicit (example). But this is simply a matter of taste.

@yosupo06
Copy link
Collaborator Author

Oh, so I prefer #include "atcoder/convolution.hpp", just because old expander is able to work continuously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants