-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum QoL Features #173
Merged
Merged
Enum QoL Features #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add value resolver for enum types
Also add `assert_success`
Refactor enum value resolver to not use macros
Drop support for nilable Enum types
Leverages a bit more flexible implementation Fix route loader spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
component:framework
component:routing
component:serializer
kind:enhancement
New functionality to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ART::Requirement::Enum
to make defining route requirements easier for enumsASPEC::Methods.assert_error
to leverage non-file versionATH
andADI
compiler specs to use itis_nilable
property fromArgumentMetadata
T
ArgumentMetadata
to allow determining if it is an "instance of" another type as well as returning the first type that matches the provided metaclass