Better WWW form data support #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
Blacksmoke16
commented
Dec 8, 2024
| rescue ex : JSON::ParseException | ASR::Exception::DeserializationException | ||
| raise ATH::Exception::BadRequest.new "Malformed JSON payload.", cause: ex | ||
| rescue ex : URI::SerializableError | ||
| raise ATH::Exception::BadRequest.new "Malformed www form data payload.", cause: ex |
There was a problem hiding this comment.
This and the other are technically wrong as this error is only raised when the underlying data is missing a required property. But I'm going to leave it and just address this more holistically as part of #290.
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Dec 8, 2024
* Leverage `URI::Params::Serializable` to handle form data request body resolution * Add `ATHA::MapQueryString` to map a request's query string into a DTO type * Add `ATH::Request#content_type_format` to return the request format's name from `content-type` header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#426 refactored how query parameters are resolved for a controller action, it only handles one-off params. You might notice yourself adding the same parameters to your actions over and over. This PR expands on the last one by introducing a new
ATHA::MapQueryStringannotation which works similarly toATHA::MapRequestBody, but for the query string of a request.This effectively allows you to use the same DTO pattern for query params as you can request bodies. This PR also allows resolving WWW form data into a DTO as well via
URI::Params::Serializable.Changelog
ATHA::MapQueryStringto map a request's query string into a DTO typeapplication/x-www-form-urlencodedbodies viaATHA::MapRequestBodyATH::Request#content_type_formatto return the request format's name fromcontent-typeheaderBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title