Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200
The existing uses of
IS_NIGHTLY
env were written in a way that works with the variable either set or not existing at all. The PR #170 enabled nightly builds by uncommenting:This version, however results in the
IS_NIGHTLY
variable always present with a valuetrue
orfalse
. This causes the workflow to be in "nightly mode" always (see https://github.com/athenavm/athena/actions/runs/11572825493/job/32213626274).This PR fixes uses of the variable in the release workflow to work with
IS_NIGHTLY=false|true
.Non-nightly run (on v* tag, nightly steps are skipped): https://github.com/athenavm/athena/actions/runs/11575072142/job/32220789839
Nightly run (on workflow_dispatch): https://github.com/athenavm/athena/actions/runs/11575009673/job/32220734895