Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IS_NIGHTLY env uses #199

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix IS_NIGHTLY env uses #199

merged 2 commits into from
Oct 29, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Oct 29, 2024

Closes #200

The existing uses of IS_NIGHTLY env were written in a way that works with the variable either set or not existing at all. The PR #170 enabled nightly builds by uncommenting:

env:
  IS_NIGHTLY: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}

This version, however results in the IS_NIGHTLY variable always present with a value true or false. This causes the workflow to be in "nightly mode" always (see https://github.com/athenavm/athena/actions/runs/11572825493/job/32213626274).

This PR fixes uses of the variable in the release workflow to work with IS_NIGHTLY=false|true.

Non-nightly run (on v* tag, nightly steps are skipped): https://github.com/athenavm/athena/actions/runs/11575072142/job/32220789839
Nightly run (on workflow_dispatch): https://github.com/athenavm/athena/actions/runs/11575009673/job/32220734895

@poszu poszu requested a review from lrettig October 29, 2024 13:11
@poszu poszu merged commit 2e32d62 into main Oct 29, 2024
23 checks passed
@poszu poszu deleted the ci-fix-is-nightly-uses branch October 29, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: release workflow failed
2 participants