Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: remove devtool #2172

Merged
merged 3 commits into from
Apr 28, 2022
Merged

enhance: remove devtool #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b24bad6
rfct: remove devtool
tangjeff0 Apr 27, 2022
57e2c3a
remove sci dep
tangjeff0 Apr 28, 2022
bb9fb30
Merge branch 'main' into delete-devtool
tangjeff0 Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
metosin/reitit #:mvn{:version "0.5.13"}
metosin/komponentit #:mvn{:version "0.3.10"}
instaparse/instaparse #:mvn{:version "1.4.10"}
borkdude/sci #:mvn{:version "0.2.5"}
tick/tick #:mvn{:version "0.5.0-RC5"}
cljc.java-time/cljc.java-time #:mvn{:version "0.1.9"}
com.rpl/specter #:mvn{:version "1.1.3"}
Expand Down
1 change: 0 additions & 1 deletion src/cljs/athens/db.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@
:win-focused? true
:athena/open false
:athena/recent-items '()
:devtool/open false
:left-sidebar/open false
:right-sidebar/open false
:right-sidebar/items {}
Expand Down
7 changes: 0 additions & 7 deletions src/cljs/athens/events.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,6 @@
(update db :athena/recent-items conj selected-page))))


(reg-event-db
:devtool/toggle
[(interceptors/sentry-span-no-new-tx "devtool/toggle")]
(fn [db _]
(update db :devtool/open not)))


(reg-event-fx
:help/toggle
[(interceptors/sentry-span-no-new-tx "help/toggle")]
Expand Down
1 change: 0 additions & 1 deletion src/cljs/athens/listeners.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
KeyCodes.K (do
(dispatch [:athena/toggle])
(.. e preventDefault))
KeyCodes.G (dispatch [:devtool/toggle])
KeyCodes.Z (do
;; Disable the default undo behaviour.
;; Chrome has a textarea undo that does not behave like
Expand Down
6 changes: 0 additions & 6 deletions src/cljs/athens/subs.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@
(:athena/open db)))


(rf/reg-sub
:devtool/open
(fn-traced [db _]
(:devtool/open db)))


(rf/reg-sub
:left-sidebar/open
(fn-traced [db _]
Expand Down
7 changes: 2 additions & 5 deletions src/cljs/athens/views.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
[athens.subs]
[athens.views.app-toolbar :as app-toolbar]
[athens.views.athena :refer [athena-component]]
[athens.views.devtool :refer [devtool-component]]
[athens.views.help :refer [help-popup]]
[athens.views.left-sidebar :as left-sidebar]
[athens.views.pages.core :as pages]
Expand Down Expand Up @@ -60,8 +59,7 @@
:gridTemplateRows "auto 1fr auto"
:grid-template-areas
"'app-header app-header app-header'
'left-sidebar main-content secondary-content'
'devtool devtool devtool'"
'left-sidebar main-content secondary-content'"
:height "100vh"
:overflow "hidden"
:sx {"WebkitAppRegion" "drag"
Expand All @@ -72,5 +70,4 @@
[app-toolbar/app-toolbar]
[left-sidebar/left-sidebar]
[pages/view]
[right-sidebar/right-sidebar]
[devtool-component]]])]])))
[right-sidebar/right-sidebar]]])]])))
Loading